Hi Paul,
The onExit() @implNote recommends the subclass delegate to the
underlying process.
For a simple subclass acting as a proxy or decorator that will provide
the best implementation.
I'll add the onExit() method to the class level recommendation for
Subclasses of Process.
Thanks, Roger.
On 4/21/2015 9:16 AM, Paul Sandoz wrote:
On Apr 21, 2015, at 2:57 PM, Roger Riggs <roger.ri...@oracle.com> wrote:
Hi Paul,
On 4/21/2015 8:29 AM, Paul Sandoz wrote:
There are statements in Process about the specified behavior of Processes
created by ProcessBuilder. That's why I included them in the @implSpec clause.
If @implSpec is only for the specifics of the method itself then where should
the behavior of ProcessBuilder created instances be specified?
I think the @implNote you have on Process.onExit about Processes from
ProcessBuilder being more efficient is fine, but that @implNote also appears to
mix stuff that is @implSpec for the method itself.
I don't see anything in that @implNote that is spec; just informative.
Process.onExit triggering waitFor to be called asynchronously in another thread
seems more spec-like to me (without defining what the executor of the CF is,
but we can probably specify what it is not i.e. the CF should be executed on
the f/j common pool).
Sorry, I meant to say "i.e. the CF should *not* be ...".
...
I am not suggesting over specifying, but currently it feels under specified by
not specifying anything :-) Given that is only so much the Process class impl
can do regardless of the JDK vendor it seems we could specify something so
sub-types can be better informed about whether they should override or not.
Paul.
