Sounds good, to make note of the style cleanup.
I suppose if this were backported to JDK 8 the source cleanup would not
be an issue.
Thanks, Roger
On 5/12/2015 3:18 PM, Ivan Gerasimov wrote:
Hi Roger.
On 12.05.2015 21:32, Roger Riggs wrote:
Hi Ivan,
Perhaps the bug description should be updated.
The original changes the bug identifies are lost in the collateral
updates.
Adding the spaces to the strings are the only changes here noticeable
from outside.
What if we keep the synopsis, but also add the summary mentioning
other cleanup work?
8074657: Missing space on a boundary of concatenated strings
Summary: Added missing spaces, fixed indentation, replaced
StringBuffer with StringBuilder
Sincerely yours,
Ivan
Roger
On 5/11/2015 7:02 PM, Ivan Gerasimov wrote:
Thanks Martin!
Yes, did that.
I also fixed indentation in some places and replaced StringBuffer
with StringBuilder.
Here's the updated webrev:
http://cr.openjdk.java.net/~igerasim/8074657/01/webrev/
Sincerely yours,
Ivan
On 12.05.2015 0:55, Martin Buchholz wrote:
Looks good.
(but I might go further and coalesce string constants for readability)
On Mon, May 11, 2015 at 2:38 PM, Ivan Gerasimov
<ivan.gerasi...@oracle.com <mailto:ivan.gerasi...@oracle.com>> wrote:
Hi all!
grep found a few places, where a space is missing.
Would you please help review this cleanup fix?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8074657
WEBREV: http://cr.openjdk.java.net/~igerasim/8074657/00/webrev/
<http://cr.openjdk.java.net/%7Eigerasim/8074657/00/webrev/>
Sincerely yours,
Ivan
