Looks good to me.
/Erik
On 2015-05-27 15:40, Mandy Chung wrote:
It’s in my repo but missing from the webrev.
diff --git a/make/launcher/Launcher-jdk.jdeps.gmk
b/make/launcher/Launcher-jdk.jdeps.gmk
new file mode 100644
--- /dev/null
+++ b/make/launcher/Launcher-jdk.jdeps.gmk
@@ -0,0 +1,36 @@
+#
+# Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
+# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+#
+# This code is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License version 2 only, as
+# published by the Free Software Foundation. Oracle designates this
+# particular file as subject to the "Classpath" exception as provided
+# by Oracle in the LICENSE file that accompanied this code.
+#
+# This code is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+# version 2 for more details (a copy is included in the LICENSE file that
+# accompanied this code).
+#
+# You should have received a copy of the GNU General Public License version
+# 2 along with this work; if not, write to the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
+# or visit www.oracle.com if you need additional information or have any
+# questions.
+#
+
+include LauncherCommon.gmk
+
+$(eval $(call SetupLauncher,javap, \
+ -DEXPAND_CLASSPATH_WILDCARDS \
+ -DNEVER_ACT_AS_SERVER_CLASS_MACHINE \
+ -DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.sun.tools.javap.Main"$(COMMA) }'))
+
+$(eval $(call SetupLauncher,jdeps, \
+ -DEXPAND_CLASSPATH_WILDCARDS \
+ -DNEVER_ACT_AS_SERVER_CLASS_MACHINE \
+ -DJAVA_ARGS='{ "-J-ms8m"$(COMMA) "com.sun.tools.jdeps.Main"$(COMMA) }'))
On May 27, 2015, at 12:48 AM, Erik Joelsson <erik.joels...@oracle.com> wrote:
Hello Mandy,
I don't see a Launcher-jdk.jdeps.gmk. Should there be one?
/Erik
On 2015-05-27 08:00, Mandy Chung wrote:
We discussed this offline and revised the proposal to group javap and classfile
library together with jdeps in jdk.jdeps module for static analysis tools to
live. The jdk.compiler module will contain the compiler and a couple of small
tools. Moving out javap and classfile library save about 1.2M uncompressed
from jdk.compiler (~11%).
The module is named after the primary tool, jdeps in this case. Tools are in
JAVA_HOME/bin directory of idk image and so which module jdeps and javap are
transparent in the idk image.
Revised webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074432/webrev.01/
This touches many langtools tests to update @modules but should be easy to
review.
$ du -s -h jdk.jdeps/com/sun/tools/*
816K jdk.jdeps/com/sun/tools/classfile
468K jdk.jdeps/com/sun/tools/javap
400K jdk.jdeps/com/sun/tools/jdeps
$ du -s -h jdk.compiler/
9.1M jdk.compiler/
Mandy
