Looks good to me, Mandy.

-Joe

On 5/27/2015 10:07 PM, Mandy Chung wrote:
An update to this patch:

Joe pointed out that javax/sql/testng has a TEST.properties file.  I now move 
the @modules from test/javax/sql/testng individual tests to the modules key in 
TEST.properties.

$ hg diff test/javax/sql/testng
diff --git a/test/javax/sql/testng/TEST.properties 
b/test/javax/sql/testng/TEST.properties
--- a/test/javax/sql/testng/TEST.properties
+++ b/test/javax/sql/testng/TEST.properties
@@ -2,3 +2,6 @@
  TestNG.dirs= .
  othervm.dirs= .
  lib.dirs = /java/sql/testng
+modules = java.sql.rowset/com.sun.rowset \
+          java.sql.rowset/com.sun.rowset.internal \
+          java.sql.rowset/com.sun.rowset.providers

Mandy

On May 27, 2015, at 4:57 PM, Mandy Chung <[email protected]> wrote:

jtreg supports a new @modules to specify the module and the internal API that a 
test depends on.  This is to prepare when the module boundaries are enforced at 
runtime.  This initial patch is contributed by several of us including 
Alexander Kulyakhtin and Alan.

Webrev at:
   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8081347/webrev.00/

Thanks
Mandy

Reply via email to