On 05/29/2015 12:20 AM, Xueming Shen wrote:
It was originally written to be the base class for both std and ext charsets providers... maybe it should
just be merged into the ExtendedCharsets class later separately.


Perhaps better to merge it now rather than separately?

Mandy

-sherman

On 5/29/2015 12:04 AM, Alan Bateman wrote:


On 29/05/2015 07:58, Xueming Shen wrote:
Please help review change to move the AbstractCharsetProvider from java.base/sun.nio.cs to
jdk.charsets/sun.nio.cs.ext. This is needed for the modules.

issue: https://bugs.openjdk.java.net/browse/JDK-8081452
webrev: http://cr.openjdk.java.net/~sherman/8081452
This looks okay to me. I just wonder if it should we renamed too as it isn't abstract.

-Alan


Reply via email to