looks good Paul, thank you
Best
Lance
On Jun 3, 2015, at 12:35 PM, Paul Sandoz <paul.san...@oracle.com> wrote:
>
> On Jun 3, 2015, at 12:06 AM, Lance Andersen <lance.ander...@oracle.com> wrote:
>
>> Hi Paul,
>>
>> All the changes seem reasonable. A couple minor suggestions
>>
>> - DriverManager.drivers() - I do not think we need to repeat the note from
>> getDrivers(), otherwise, I would use {@code} vs <code> in the new javadoc
>> comment
>
> Removed.
>
>
>> - DriverManagerTests.test19() - For the new test, if you could add a simple
>> comment about the test, it would keep it consistent with the other tests,
>> otherwise I can do it later
>>
>
> Added.
>
> Webrev updated in place
>
> Thanks,
> Paul.
>
>> Best
>> Lance
>>
>> On Jun 2, 2015, at 9:37 AM, Paul Sandoz <paul.san...@oracle.com> wrote:
>>
>>> Hi,
>>>
>>> Please review a follow up to Stuart's Enumeration.asIterator patch that
>>> adds some Stream return methods to classes where there is only Enumeration
>>> returning methods to support traversal:
>>>
>>> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8081678-enumeration-and-stream/webrev/
>>>
>>> I took the opportunity to sprinkle some Enumerator.asIterator impls.
>>>
>>> I originally included some methods on ClassLoader but Alan wisely warned me
>>> away from doing that as this area is likely to be impacted by modularity.
>>>
>>> There is one small area of uncertainty with NetworkInterface. Can the
>>> following method ever return null?
>>>
>>> 342 public static Enumeration<NetworkInterface> getNetworkInterfaces()
>>> 343 throws SocketException {
>>> 344 NetworkInterface[] netifs = getAll();
>>> 345
>>> 346 // specified to return null if no network interfaces
>>> 347 return netifs != null
>>> 348 ? enumerationFromArray(netifs)
>>> 349 : null;
>>> 350 }
>>>
>>> Contrary to the comment i cannot find any specification. For the stream
>>> returning method, networkInterfaces, i have specified this to return an
>>> empty stream, thus it might be good to update the enumeration returning
>>> method as well to say whether it returns null or an empty enumeration.
>>>
>>> Paul.
>>
>> <oracle_sig_logo.gif>
>>
>> Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering
>> 1 Network Drive
>> Burlington, MA 01803
>> lance.ander...@oracle.com
>>
>>
>>
>
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
