Typo ...
On 4/06/2015 4:04 PM, David Holmes wrote:
Hi Chris,
On 3/06/2015 1:20 PM, Chris Plummer wrote:
Please review the following:
Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8081771
This review only concerns the changes to ProcessTool.java. The
Your new method needs javadoc explaining its usage, and in particular
what addTestVmAndJavaOptions actually refers to. Also a comment on why
the explicit -cp is added, but on under that arg, would be useful.
but only under that arg ...
David
Thanks,
David
CDSJDITests and filemapp.cpp changes will be committed under CR
JDK-8054386, but they rely on this change to ProcessTool.java, so both
CRs will be pushed together. See the following thread for the
JDK-8054386 review:
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-June/014923.html
thanks,
Chris
