Yes, the tests look good to me too :-)
I'd suggest a couple of things:
Bug6794483Test: add 8080908 to the bug tag, and year "2015," to the
header. I added a link to JDK-6794483 from JDK-8080908.
LSSerializerTest: was missing a bug tag. I believe the original test was
for 6439439, so add: @bug 6439439, 8080906 to the test class and @bug
8080906 to test "testDefaultLSSerializer". This test would have been
helpful in detecting the failure of loading LSSerializerImpl in a Jigsaw
build. You may add a note to the test to indicate that it would fail in
a Jigsaw build, and that the issue will be fixed in JDK-8080266.
The changeset will be split into two (JDK-8080906 & JDK-8080908) when
check in.
Thanks,
Joe
On 6/5/2015 4:29 AM, Lance Andersen wrote:
Hi Frank,
These seem OK. I am sure Joe will also review when he wakes up in his
part of the world :-)
Best
Lance
On Jun 5, 2015, at 3:45 AM, Frank Yuan <[email protected]
<mailto:[email protected]>> wrote:
Hi Joe and all
I have been working on the test task of JEP 255 Xerces Updates.
Here I would invite you to review the changes for 2 bugs of this task:
1. JDK-8080906 Develop test for Xerces Update: DOM L3 Serializer
To verify default LSSerializer is Xalan dom 3 serializer
2. JDK-8080908 Develop test for Xerces Update: XPointer
To verify Xerces revision 415823: XERCESJ-1134. It should have been
fixed
in JDK-6794483, however, the test Bug6794483Test.java need to be
revised to
really cover this bug.
I also added module dependencies for exported API in this path, it's
recommended for Jigsaw change, refer to
https://wiki.se.oracle.com/display/JPG/@modules+in+JTReg+tests
The webrev is at
http://cr.openjdk.java.net/~fyuan/8080906_8080908/webrev.00/, your
comment
will be appreciated.
Best Regards
Frank
<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance
Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>
