On 6/24/15 4:10 PM, Paul Sandoz wrote:
On Jun 24, 2015, at 10:05 AM, Amy Lu <[email protected] <mailto:[email protected]>> wrote:
Testcase testStable was newly introduced in JDK-8129120 in DistinctOpTest, this test should be marked as serialization-hostile. (such tests will ignored by by lambda serialization testing framework). testSkipLimitOpsWithNonSplittingSpliterator from SliceOpTest also need same change.

Please review and sponsor this change:

bug: https://bugs.openjdk.java.net/browse/JDK-8129759
webrev: http://cr.openjdk.java.net/~amlu/8129759/webrev.00/ <http://cr.openjdk.java.net/%7Eamlu/8129759/webrev.00/>


+1

  193     @Test(groups = { "serialization-hostile" })
  194     public void testSkipLimitOpsWithNonSplittingSpliterator() {

I wonder why you needed to add since the changeset for JDK-8129120 did not modify SliceOpTest.

Paul.

Thank you Paul for reviewing this.

With change of JDK-8129120, this testcase is not suitable for SAND testing. Other similar testcases in this same test, like testSkipLimitOps, testSkipOps are all previously marked as serialization-hostile.

Thanks,
Amy

Reply via email to