Hi Frank, The proposed changes look good to me.
best regards, -- daniel On 24/06/15 09:58, Frank Yuan wrote:
Hi, Would you like to have a review for bug https://bugs.openjdk.java.net/browse/JDK-8080266? This bug is caused by jigsaw change, the context class loader can't load internal resource which is in a named module any more. To fix it, LSSerializerImpl shall invoke ResourceBundle.getBundle(resourceName) instead of ResourceBundle.getBundle(resourceName, locale, classloader) to create CharInfo instance, that will getBundle with the module of the caller(here it's java.xml module). This patch also forces to use the internal XMLEntities.properties because the default xml character entity reference should always be applied. The webrev is at: http://cr.openjdk.java.net/~fyuan/8080266/webrev.00/ Any comment will be appreciated. Thanks, Frank
