On 24/06/2015 20:04, Brian Burkhalter wrote:
Please review at your convenience.

Issue:  https://bugs.openjdk.java.net/browse/JDK-8042377
Patch:  http://cr.openjdk.java.net/~bpb/8042377/webrev.00/

The use of try-with-resources in FilteredOutputStream.close() is replaced with 
explicit handling of IOExceptions potentially thrown by flush() or close(). A 
test covering all cases is added.

I see the mails about AtomicBoolean. There shouldn't be any issue using it in this class but not clear why it's in this patch.

The replacement of try-with-resources to avoid the self-suppression case looks okay.

-Alan

Reply via email to