Hi Roger,
Generally looks okay; a few comments and suggestions
114 long cpulooptime = 100; // 100 ms
How about
cpuLoopTime
instead? Same comment for the other variables that don't follow
camel-case conventions.
284 long cpumillis =
Long.valueOf(args[nextArg++]);
285 long cpuTarget = getCpuTime() + cpumillis
* 1_000_000L;
286 while (getCpuTime() < cpuTarget) {
Is it correct to multiply cpu-millis by 1e6 rather than 1e3?
-Joe
On 7/7/2015 11:52 AM, Roger Riggs wrote:
Please review this ProcessHandle test change to cleanup intermittent failures.
The cpuloop timing uses the cputime of the spawned process and the
test runs fewer iterations and relaxes the threshold.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-info-8098852/
Issue:
https://bugs.openjdk.java.net/browse/JDK-8098852
Thanks, Roger
