Hi Sidharth,
You are totally right, sorry for that.
Actually, it seems to be Eclipse Mars bug, since it shows double "}". I will
open a case there.
Thanks,Ahmed From: A. Sundararajan
<sundararajan.athijegannat...@oracle.com>
To: core-libs-dev@openjdk.java.net; Ahmed Ashour <asash...@yahoo.com>;
"nashorn-...@openjdk.java.net" <nashorn-...@openjdk.java.net>
Sent: Tuesday, July 14, 2015 12:38 PM
Subject: Re: Fwd: Re: [PATCH] javax,script.ScriptEngineFactory Typos
Hi Ahmed,
Did you build the forest with that change or just "found" by code
reading? Because {@code requires } to end it. So, those were not 'extra'
'}' chars in doc comments.
Also, you can check javadoc output is correct. i.e., no extra "}".
http://docs.oracle.com/javase/8/docs/api/javax/script/ScriptEngineFactory.html#getProgram-java.lang.String...-
The other diffs being simple white space removals, I/we'll take care as
part of another fix.
Thanks,
-Sundar
On Tuesday 14 July 2015 09:30 AM, A. Sundararajan wrote:
> Forwarding this contribution from Ahmed to core-libs-dev alias as the
> change is going to be in "jdk/java.scripting/javax.script" code.
>
> PS. I'll send out webrev after build, test.
>
> Thanks Ahmed,
> -Sundar
>
>
> -------- Forwarded Message --------
> Subject: Re: [PATCH] javax,script.ScriptEngineFactory Typos
> Date: Fri, 10 Jul 2015 07:46:40 +0200
> From: Ahmed Ashour <asash...@yahoo.com>
> To: nashorn-...@openjdk.java.net
>
>
>
> Dear all,
>
> Please find below a proposed patch based on jdk9/dev.
>
> Thanks,
> Ahmed
>
>
> diff -r b526c2584b4b
> src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java
> ---
> a/src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java
> Wed Jul 08 21:54:32 2015 -0400
> +++
> b/src/java.scripting/share/classes/javax/script/ScriptEngineFactory.java
> Thu Jul 09 08:10:26 2015 +0200
> @@ -160,7 +160,6 @@
> * }
> * ret += ")";
> * return ret;
> - * }
> * } </pre>
> *
> * @param obj The name representing the object whose method is to
> be invoked. The
> @@ -190,8 +189,6 @@
> *
> * @param toDisplay The String to be displayed by the returned
> statement.
> * @return The string used to display the String in the syntax of
> the scripting language.
> - *
> - *
> */
> public String getOutputStatement(String toDisplay);
>
> @@ -208,14 +205,12 @@
> * retval += statements[i] + ";\n";
> * }
> * return retval += "?>";
> - * }
> * }</pre>
> *
> * @param statements The statements to be executed. May be
> return values of
> * calls to the <code>getMethodCallSyntax</code> and
> <code>getOutputStatement</code> methods.
> * @return The Program
> */
> -
> public String getProgram(String... statements);
>
> /**
> @@ -225,5 +220,5 @@
> *
> * @return A new <code>ScriptEngine</code> instance.
> */
> - public ScriptEngine getScriptEngine();
> + public ScriptEngine getScriptEngine();
> }
>
>
>
