On 19/08/2015 16:37, Miroslav Kos wrote:
Hi everybody,

I am sending changes for review.

CCC: http://ccc.us.oracle.com/8131667
JBS: https://bugs.openjdk.java.net/browse/JDK-8131667
webrev: http://cr.openjdk.java.net/~mkos/8131667/jaxws.01/

It's about migrating to standard java.util.ServiceLoader. This part of service discovery was implemented previously "own" way. There are some changes in javadoc and implementation has been refactored in order to use same code as is in JAX-B and SAAJ.
I skimmed through this and it mostly looks okay. One thing that probably should be re-examined is the catch Exception in fromJDKProperties as an exception accessing or parsing jaxws.properties will be difficult to diagnose with the code as it is.

-Alan

Reply via email to