Hi Lance,
The change looks good.
-Joe
On 8/25/2015 11:29 AM, Lance Andersen wrote:
Hi,
Looking for a reviewer for 8134426 This change adds a serialVersionUID field
to the required javax.transaction classes as well as some basic tests.
Once approved, I will work to push the same changes to the relevant JTA project working with the Java EE team
output from serialver:
----------------
jdk 1.6 (OSX)
serialver -classpath classes.jar javax.transaction.InvalidTransactionException
javax.transaction.InvalidTransactionException: private static final long
serialVersionUID = 3597320220337691496L;
ljanders-mac:Classes ljanders$ serialver -classpath classes.jar
javax.transaction.TransactionRequiredException
javax.transaction.TransactionRequiredException: private static final long
serialVersionUID = -1898806419937446439L;
ljanders-mac:Classes ljanders$ serialver -classpath classes.jar
javax.transaction.TransactionRolledbackException
javax.transaction.TransactionRolledbackException: private static final long
serialVersionUID = -3142798139623020577L;
java ee 6
serialver -classpath javaee.jar javax.transaction.InvalidTransactionException
javax.transaction.InvalidTransactionException: private static final long
serialVersionUID = 3597320220337691496L;
ljanders-mac:lib ljanders$ serialver -classpath javaee.jar
javax.transaction.TransactionRequiredException
javax.transaction.TransactionRequiredException: private static final long
serialVersionUID = -1898806419937446439L;
ljanders-mac:lib ljanders$ serialver -classpath javaee.jar
javax.transaction.TransactionRolledbackException
javax.transaction.TransactionRolledbackException: private static final long
serialVersionUID = -3142798139623020577L;
---------------
The webrev can be found at http://cr.openjdk.java.net/~lancea/8134426/webrev/.
Also waiting on a JPRT run to complete to verify tests run outside of my
environment.
Best
Lance
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected]
