The changes look fine to me too.
-Chris.
On 04/09/15 16:04, Daniel Fuchs wrote:
Hi Vyom,
I'm not a net/JNI expert but what you are proposing
looks good to me too. Ivan has already given his assent.
Unless I hear objections - or comments from other reviewers,
I will sponsor this change and push it for you (I'll wait
for Monday).
best regards,
-- daniel
On 02/09/15 15:55, Ivan Gerasimov wrote:
This looks good.
In general, it might be more appropriate to review this on
net-...@openjdk.java.net alias.
Sincerely yours,
Ivan
On 02.09.2015 16:22, Vyom Tewari wrote:
Hi everyone,
Can you please review my changes for below bug.
Bug:
JDK-8080486 : JNI exception pending in
jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c
Webrev:
http://cr.openjdk.java.net/~dfuchs/vyom/8080486/webrev.01
This change ensure that we immediately return if an exception has been
raised (result == NULL) by GetMethodId/NewGlobalRef or proceed to the
next statement if there is no JNI pending exception.
Thanks,
Vyom
