Hi Joe, Overall this looks good. I only have a couple of minor observations related to internal documentation.
1. FdLibm.java Lines 158-166: The verbiage in the note might benefit from a little reworking. 2. HypotTests.java Line 46: “Commutative” is misspelled. Thanks, Brian On Sep 21, 2015, at 6:22 PM, Joseph D. Darcy <[email protected]> wrote: > Please review the next portion of the port of fdlibm to Java: > > JDK-7130085 Port fdlibm hypot to Java > http://cr.openjdk.java.net/~darcy/7130085.0/ > > As before with pow, this isn't necessarily the end state of the code we'd > like to stop at, but it should be sufficiently idiomatic Java for an initial > port. > > To make comparison against the original C algorithm easier, I listed the C > version of hypot as the base file to compare FdLibm.java against.
