I'd like to see an additional test case for the cases where rounding is *not* needed. Currently, there are only tests for where rounding is needed. It needs one more test line for after 1970 and one for before 1970.
thanks Stephen On 14 October 2015 at 10:53, nadeesh tv <nadeesh...@oracle.com> wrote: > Hi all, > > Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8134928 > > Issue- java.time.Instant.truncatedTo(TemporalUnit unit) is truncating up if > the year < 1970 > > BugId - https://bugs.openjdk.java.net/browse/JDK-8134928 > > webrev - http://cr.openjdk.java.net/~pchopra/8134928/webrev.01/ > > -- > Thanks and Regards, > Nadeesh TV >