Hi Lance,
yes, it makes sense - after creating it and reviewing I fixed additional issues - please, check new version of a patch:
http://cr.openjdk.java.net/~mkos/8139743/jaxws.02/
http://cr.openjdk.java.net/~mkos/8139743/specdiff.02/

Thanks
Miran

On 16/10/15 18:12, Lance Andersen wrote:
Hi Miran

On Oct 16, 2015, at 11:49 AM, Miroslav Kos <[email protected] <mailto:[email protected]>> wrote:

Hi Lance,
the javadoc fixes are just about formal issues (<tt>...</tt> for {@code .. }, broken links etc.) - there are no other changes.

Understand, but the specdiff makes it easier to see that there are no untended changes especially with the size.

Best
Lance

Thanks
Miran


On 16/10/15 17:26, Lance Andersen wrote:
Hi Miran

Can you please provide a specdiff as that makes it easier for javadoc review

Best
Lance
On Oct 16, 2015, at 11:14 AM, Miroslav Kos <[email protected]> wrote:

Hi,
there is a bulk update of JAX-B/WS from upstream projects -
webrev: http://cr.openjdk.java.net/~mkos/8139743/jaxws.01/ <http://cr.openjdk.java.net/%7Emkos/8139743/jaxws.01/> more details in issue desc: https://bugs.openjdk.java.net/browse/JDK-8139743

Could I ask for a review?

It's quite big (2570  lines changed):
* many javadoc fixes
* some performance and other fixes for SAAJ
* findbugs issues

There are issue list in the JBS, many of listed bugs were fixed in JDK already (they are on the list because of backporting to standalone)

Thanks
Miran


<Mail Attachment.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>





<http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif><http://oracle.com/us/design/oracle-email-sig-198324.gif>
<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
[email protected] <mailto:[email protected]>




Reply via email to