I just pulled the latest hs-rt, and got about 30 new jvmci tests that
are using "/../../test/lib". I can fix them with this push, or file a
separate bug or send out a fix after I do this push. If I fix with this
push, do you want another review? I'll test with jprt and run the jvmci
tests locally.
thanks,
Chris
On 10/23/15 7:50 AM, Staffan Larsen wrote:
Looks good! Thanks for doing this.
/Staffan
On 23 okt. 2015, at 07:54, Chris Plummer <[email protected]> wrote:
Hello,
Please review the following fix for 8140189:
http://cr.openjdk.java.net/~cjplummer/8140189/webrev.00/webrev.hotspot
http://cr.openjdk.java.net/~cjplummer/8140189/webrev.00/webrev.jdk
https://bugs.openjdk.java.net/browse/JDK-8140189
Please also see the following CR, which has much more extensive discussion of
the problem:
jtreg produces class files outside the JTwork directory
https://bugs.openjdk.java.net/browse/CODETOOLS-7901527
All the diffs for the tests simply replace "/../../test/lib" with "/test/lib".
The changes in TEST.ROOT are what allow this. It is probably much easier to look at the patch than
to look at each file in the webrev. All the test diffs look pretty much like the following:
- * @library /testlibrary /../../test/lib
+ * @library /testlibrary /test/lib
or
- * @library /../../test/lib/share/classes
+ * @library /test/lib/share/classes
Tested with jprt. Also ran the following jtreg tests on a linux/x64 host with a
fastdebug build:
-Ran all hotspot jtreg tests.
-Ran all modified jdk jtreg tests.
-Ran jdk tier1 and tier2 jtreg tests.
There were some failures and errors, but they were replicated when testing with
a clean repo also and are unrelated to my changes.
thanks,
Chris
