On 30/10/2015 21:30, Xueming Shen wrote:
Hi,
Thanks for the comments/suggestions. Here are the updated webrevs with
minor changes here
and there based on the feedback.
I spent time going through the changes in jdk repo and it looks very good.
One thing that isn't clear to me is why StringUTF16 needs a native
method to test for big endian. Could it use Unsafe::isBigEndian or is
there a non-obvious bootstrapping/initialization issue here?
The additional test coverage looks quite good but I'm guessing many of
these tests overlap with existing tests. Are you planning to leave them
in the CompactStrings directory? I assume it would make more sense to
move them up to the String directory. I was also wondering if more of
the existing tests should be updated to run them both ways. In passing,
SerializationUtils has a semi-colon at L47 that looks a bit odd.
-Alan.
