Hi vyom, On 11/25/2015 05:29 PM, vyom wrote: > Hi All, > > Please review my changes for below bug. > > Bug: JDK-6856817 : Poor performance of Writer#append with CharBuffer > Webrev: http://cr.openjdk.java.net/~vtewari/6856817/webrev0.4/
Interesting change. But, I think the "null" handling in new OSW.append methods is incorrect. Javadoc says that those methods should behave exactly as: out.write(csq.toString()) or: out.write(csq.subSequence(start, end).toString()) If CharSequence is null, we should throw NullPointerException, not doing any "null" mangling, as your patch does? If so, can you please fix this and add more tests? Cheers, -Aleksey
