Hi Maurizio,

Updated webrevs:
  http://cr.openjdk.java.net/~shade/8085796/webrev.langtools.04/
  http://cr.openjdk.java.net/~shade/8085796/webrev.jdk.05/

On 11/27/2015 10:13 PM, Maurizio Cimadamore wrote:
> Looks great - the only minor quibble is that now StringConcat looks like
> a regular javac context class; it even has an instance method - it's
> therefore best to follow usual initialization pattern for javac components:

That makes sense. I had a concern that Gen and StringConcat are
circularly dependent on each other, but this seems to be handled by
exposing the underconstructed Gen early.

Thanks,
-Aleksey


Reply via email to