Hi,
While it is kinda understandable to have LocalDate.toEpochSecond(...)
to get the epoch seconds since 1970.1.1, with the assumption of the
time is at the midnight of that day. It is strange to have the Local/OffsetTime
to have two public methods with the assumption of the "date" is at epoch
year/month/day. What's the use case/scenario for these two proposed
methods?
-Sherman
On 11/30/2015 06:36 AM, Stephen Colebourne wrote:
The method Javadoc (specs) for each of the three new methods needs to
be enhanced.
For the date ones it needs to say
"The resulting date will have a time component of midnight at the
start of the day."
For the time ones it needs to say
"The resulting time will be on 1970-01-01."
Some of the line wrapping in the tests looks like it is not indented correctly.
Otherwise looks fine,
thanks
Stephen
On 30 November 2015 at 11:50, nadeesh tv<nadeesh...@oracle.com> wrote:
Hi all,
Please review a fix for
Bug Id -https://bugs.openjdk.java.net/browse/JDK-8143413
Issue - add toEpochSecond methods for efficient access
webrev - http://cr.openjdk.java.net/~ntv/8143413/webrev.01/
-- Thanks and Regards,
Nadeesh TV
