On 2 Dec 2015, at 20:23, Roger Riggs <roger.ri...@oracle.com> wrote:
> Please review the java.lang.ref.Cleaner and tests following the > recommendation to simplify the public > interface to support only phantom cleanup. > > Webrev: > http://cr.openjdk.java.net/~rriggs/webrev-cleaner-8138696/ > > Javadoc: > http://cr.openjdk.java.net/~rriggs/cleaner-doc/index.html Just a few minor inconsistencies, and subjective wording suggestions: 1) "Cleaner manages a set of …” -> "A Cleaner manages a set of …” 2) "related to"- > "relating to” ?? 3) "Return a new Cleaner” -> "ReturnS a new Cleaner” 4) " Cleanable is a registered cleaning function.” -> “A Cleanable is a registered cleaning function." 5) "Unregister the Cleanable and invoke the …” -> "UnregisterS the Cleanable and invokeS the …” 6) Is a Cleanable a @FunctionalInterface ? -Chris.