On 15 Dec 2015, at 19:26, Mandy Chung <[email protected]> wrote:
>> On Dec 15, 2015, at 10:41 AM, Chris Hegarty <[email protected]> wrote: >> >> >> Webrev updated in-place. > > Thank you for moving it to java.lang.reflect. > > Formatting nit: since you make generateProxyClass method package-private, > line 323 & 335-336 needs to be adjusted to align with the line above. > > Thanks for renaming the system property. Do you mind renaming it to > “jdk.proxy.ProxyGenerator.saveGeneratedFiles” as “java.” may be interpreted > as standard system property? “jdk.proxy” may not be the best candidate that > we can revisit later. I’ll do this before pushing. Thanks, -Chris.
