On 6 Jan 2016, at 04:20, David Holmes <david.hol...@oracle.com> wrote:
> Hi Chris, > > Hotspot comment change looks okay.:) Thanks David. > I see a lot of hotspot tests that include > > @modules java.base/sun.misc > > but I don't understand why it is present in the few cases I looked at eg: > > hotspot/test/gc/g1/TestShrinkAuxiliaryData15.java The dependency on sun.misc is coming from the test library, specifically jdk.test.lib.Utils. Quite a few tests in the hotspot repo use the test library, so have this dependency ( on sun.misc.Unsafe ). > so not sure when it needs to be converted to jdk.internal.misc It is on my list to update these tests, see 8140608 [1]. I punted doing this with the Unsafe move, as I was unhappy with the test coverage of sun.misc.Unsafe. Paul has since added some additional tests [2] that have variants that cover both jdk.internal.misc.Unsafe and sun.misc.Unsafe, so I think the hotspot tests can now be updated to only use jdk.internal.misc. I’ll move 8140608 forward over the next few weeks. -Chris. [1] https://bugs.openjdk.java.net/browse/JDK-8140608 [2] http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/d84bd22ab531 > Thanks, > David > > On 5/01/2016 12:02 AM, Chris Hegarty wrote: >> sun.misc.VM provides a low-level interface for a small number >> of specific operations with the VM. In preparation for JEP 260, >> this class should be moved out of sun.misc and located in a >> non-exported package [. >> >> http://cr.openjdk.java.net/~chegar/8145544/00/ >> >> Note: as in other areas some tests that require access to >> internal APIs have been updated to use types from a more >> stable package, sun.security.x509. >> >> -Chris. >> >> [1] https://bugs.openjdk.java.net/browse/JDK-8145544
