Hi, Please review the attached webrev which addresses some changes we needed to make to the sharding API. The CCC has been approved. The webrev can be found at: http://cr.openjdk.java.net/~lancea/8146803/webrev.00/
Here is a brief description of the changes -ConnectionPooledDataSource needed to add a PooledConnectionBuilder as like DataSource and XADataSource this will create a physical connection and the ShardingKey will be needed - PooledConnectionBuilder - is used to create a PooledConnection ->physical connection so it needed access to the ShardingKey - CommonDataSource added createShardingKeyBuilder making it available to DataSource, XADataSource and ConnectionPoolDatasource. - DataSource/XADataSource removed createShardingKeyBuilder as it now is on CommonDataSource which they both extend - XAConnection removed the setShardingKey methods. Having the methods on Connection should be adequate as the ShardingKey is needed for the Connection which they already exist on. -XAConnectionBuilder had a minor typo in the javadoc Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com
