Shouldn't you also include the FileOuputStream in try-with-resources? --Max
> On Jan 28, 2016, at 5:32 PM, Chris Hegarty <chris.hega...@oracle.com> wrote: > > > On 28 Jan 2016, at 00:35, Steve Drach <steve.dr...@oracle.com> wrote: > >> Please review a small change to the zipfs test library. >> >> Issue: https://bugs.openjdk.java.net/browse/JDK-8147607 >> Webrev: http://cr.openjdk.java.net/~sdrach/8147607/webrev >> >> This change uses the public jdk.security.jarsigner.JarSigner API rather than >> the API exposed by sun.security.tools.jarsigner. > > Thanks for doing this Steve. Your changes look fine. > > -Chris.