I think that this is fine now, but Roger/others should also chime in. thanks Stephen
On 2 March 2016 at 15:17, nadeesh tv <nadeesh...@oracle.com> wrote: > Hi, > Stephen, Thanks for the comments. > Please see the updated webrev > http://cr.openjdk.java.net/~ntv/8030864/webrev.02/ > > Regards, > Nadeesh TV > > > On 3/2/2016 5:41 PM, Stephen Colebourne wrote: >> >> Remove "Subclass can override the default implementation for a more >> efficient implementation." as it adds no value. >> >> In the default implementation of >> >> epochSecond(Era era, int yearofEra, int month, int dayOfMonth, >> int hour, int minute, int second, ZoneOffset zoneOffset) >> >> use >> >> prolepticYear(era, yearOfEra) >> >> and call the other new epochSecond method. See dateYearDay(Era era, >> int yearOfEra, int dayOfYear) for the design to copy. If this is done, >> then there is no need to override the method in IsoChronology. >> >> In the test, >> >> LocalDate.MIN.with(chronoLd) >> >> could be >> >> LocalDate.from(chronoLd) >> >> Thanks >> Stephen >> >> >> >> >> >> >> On 2 March 2016 at 10:30, nadeesh tv <nadeesh...@oracle.com> wrote: >>> >>> Hi all, >>> >>> Please review an enhancement for a garbage free epochSecond method. >>> >>> Bug ID: https://bugs.openjdk.java.net/browse/JDK-8030864 >>> >>> webrev: http://cr.openjdk.java.net/~ntv/8030864/webrev.01 >>> >>> -- >>> Thanks and Regards, >>> Nadeesh TV >>> > > -- > Thanks and Regards, > Nadeesh TV >
