On 3/25/2016 12:32 PM, Aleksej Efimov wrote:
Hi Rob,
Sure!
Adding corelibs-dev and Joe (JDK9 reviewer).
Hi Joe,
Can you, please, review the backported changes: The source fix is
identical (except file paths), but regression test changes differs.
Looks good, Aleksej.
Best,
Joe
Best Regards,
Aleksej
On 03/25/2016 06:07 PM, Rob McKenna wrote:
Hi Aleksej,
I'd like to see a review of the 8 change before approval.
-Rob
On 25/03/16 03:06, Aleksej Efimov wrote:
Hi,
Please, approve the backport of JDK-8150704 to JDK8. JAXP classes
source fix
applies cleanly after reshuffling.
The only discrepancy is the test changes:
In JDK9 the issue was tested by extending the functionality of
existing JDK9
test: jaxp/javax/xml/jaxp/unittest/transform/TransformerTest.java
Current test and test suite is absent in JDK8 and the added test
case was
backported to JDK8 as a standalone test application:
jdk/test/javax/xml/jaxp/transform/8150704 - JDK8 webrev is provided.
Also the cleanup changes of test code wasn't backported because
tests are
absent in JDK8.
JTREG/JCK testing shows no failures with backported changes.
Best Regards,
Aleksej
JBS:
https://bugs.openjdk.java.net/browse/JDK-8150704
JDK8 webrev:
http://cr.openjdk.java.net/~aefimov/8150704/8/00/
JDK9 changeset:
http://hg.openjdk.java.net/jdk9/dev/jaxp/rev/0fe7231b64a6
JDK9 Review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-March/039272.html
