Patch looks Ok to me.

Rémi

----- Mail original -----
> De: "Claes Redestad" <[email protected]>
> À: "Remi Forax" <[email protected]>
> Cc: "Peter Levart" <[email protected]>, "Mandy Chung" 
> <[email protected]>, "jigsaw-dev"
> <[email protected]>, "core-libs-dev" 
> <[email protected]>
> Envoyé: Mercredi 30 Mars 2016 13:14:39
> Objet: Re: RFR: 8152641: Plugin to generate BMH$Species classes ahead-of-time
> 
> Hi,
> 
> On 2016-03-30 13:11, Remi Forax wrote:
> > Hi Claes,
> > Did you considere to use
> >    return c.asSubclass(BoundMethodHandle.class);
> > instead of
> >    return (Class<? extends BoundMethodHandle>)c;
> > to avoid the @SupressWarnings, like in generateConcreteBMHClass ?
> 
> no, but it's a good cleanup. :-)
> 
> Updated in-place: http://cr.openjdk.java.net/~redestad/8152641/webrev.03/
> 
> /Claes
> 
> 

Reply via email to