Hi Joe, Overall it is OK.
I might have considered using @Beforeclass vs a static block in the test. Also, once you check the property, you could then set your offset and avoid the extra check and need for the isWindows boolean. That is more of a style choice though. I am OK either way, I just try to leverage the testng annotations when I can. Best Lance > On Apr 27, 2016, at 3:06 PM, huizhe wang <huizhe.w...@oracle.com> wrote: > > Hi, > > Please review the following issue and fix: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8154220 > webrev: http://cr.openjdk.java.net/~joehw/jdk9/8154220/webrev/ > > Thanks, > Joe > <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>
