On 02/05/16 20:06, Mandy Chung wrote:
On May 2, 2016, at 10:59 AM, Daniel Fuchs <daniel.fu...@oracle.com> wrote:
Hi Mandy,
I applied the suggested changes.
http://cr.openjdk.java.net/~dfuchs/8139982_webrev/webrev.08/index.html
Looks very good and much cleaner. Nits:
166 // The LoggingMXBeanSupport class uses reflection to determine
s/LoggingMXBeanSupport/LoggingMXBeanAccess/
Also renaming the variable name “support” to “loggingAccess” (or something like
that) might help.
You can fix it up before you push. No need to generate a new webrev.
Thanks! Done.
-- done
Mandy
