Thanks, Vladimir.
BTW, automated build+test has revealed that my test's simple array of
expected values doesn't cut it in the face of other [endian|bit]ness-es.
For now, I need to skip checking of a couple of locals until something
more robust can be added.
Thanks,
-Brent
jdk/test/java/lang/StackWalker/LocalsAndOperands.java
***************
*** 292,295 ****
"0",
! "1000000",
! "0",
"1293080650",
--- 292,295 ----
"0",
! null, // skip, fix in 8156073
! null, // skip, fix in 8156073
"1293080650",
On 05/04/2016 01:33 AM, Vladimir Ivanov wrote:
Looks good.
Best regards,
Vladimir Ivanov
On 5/3/16 10:00 PM, Brent Christian wrote:
Hi,
Please review this change which fixes buggy behavior (including SEGV) in
the experimental LiveStackFrame feature of StackWalker.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8147039
Webrev:
http://cr.openjdk.java.net/~bchristi/8147039/webrev.02/
As suggested in the bug report, stack walking is reimplemented using
javaVFrame/vframe::java_sender. The native StackWalkerAnchor class is
updated (and renamed) with a similar interface and function to
vframeStream. I've also removed the now-unneeded
vframeStreamCommon::java_frame() function, added by 8140450.
Thanks,
-Brent
