On 04/05/2016 20:54, Xueming Shen wrote:
Thanks Claes! fixed and webrev has been updated.
http://cr.openjdk.java.net/~sherman/8150496/webrev
sherman
I skimmed through this and it looks quite. I just wonder if we should
check in the micro benchmarks as it is likely we'll need those again in
the future.
One thing that isn't clear (to me anyway) is the change to detecting
\u0000 in the normalization code. Do we have any cases where
IllegalPathException is thrown?
In checkAccess there is a comment about needing to read the CEN. It this
method needed? I would check that ZipFileSystemProvider should just need
to invoke exists (+ checks when w or x modes).
In cen then the versionMade-attrsEx is commented out, should they be
removed?
-Alan.
