Looks good. Best regards, Vladimir Ivanov
PS: regarding naming, makeVarHandleMethodInvoker is shorter and as informative. Since there are only 2 flavors of invokers for VarHandles (for MHs there are also basic invokers), there's no need to explicitly mention the modes in method names.
On 5/10/16 4:36 PM, Paul Sandoz wrote:
Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8156486-varHandleExactInvoker/webrev/ A bug slipped in with recent VarHandle implementation improvements, and this was not caught by relevant tests. The MethodHandle returned from MethodHandles.varHandleExactInvoker performed an incorrect match using erased signatures. Ooops. I fixed this by consolidating the lambda form generation for exact and generic VH invokers. The tests are also updated, primarily to VarHandleTestMethod* (changes to other areas are minor clean ups) to correctly test the 4 ways to obtain a MethodHandle to a VarHandle access mode method, and to correctly differentiate between testing exact and generic invocation. Thanks, Paul.
