Hi Mandy,

I played with that a bit (-I/-addmods) and it looks good.

  92 main.opt.I=\
93 \ -I -inverse Analyzes the dependences per other given options\n\ 94 \ and then find all artifacts that directly\n\ 95 \ and indirectly depend on the matching nodes.\n\ 96 \ This is equivalent to the inverse of\n\ 97 \ compile-time view analysis and print\n\ 98 \ dependency summary. This option must use\n\ 99 \ with -requires, -package or -regex option.

Maybe it would be useful to clarify that the 'artifacts'
found by the -I option are jars and modules (not classes and packages).
That was not clear for me when I started playing with it, until
you explained it.

Also it's not clear if there's any difference between
   -m <module> and
   -addmods <module>
(if you give a single module to addmods).
Maybe there isn't and maybe it's fine.

No need for a new webrev - I'll let you decide whether you want
to bring in the above clarifications...

best regards,

-- daniel


On 14/05/16 06:48, Mandy Chung wrote:
Daniel,

I have added more tests and fixed a few issues
  http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8156575/webrev.02/

I also created a test case similar to yours.

This patch applies on top of:
  http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8156680/webrev.02/

for JDK-8156680: jdeps implementation refresh

Thanks
Mandy


Reply via email to