> On May 20, 2016, at 7:24 AM, Mandy Chung <[email protected]> wrote: > >> >> On May 19, 2016, at 11:39 PM, Alan Bateman <[email protected]> wrote: >> >> >> >> On 20/05/2016 04:55, Mandy Chung wrote: >>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157391/webrev.00/index.html >>> >>> tools/jdeps/modules/GenModuleInfo.java >>> tools/jdeps/modules/TransitiveDeps.java >>> tools/jdeps/modules/InverseDeps.java >>> >>> These tests still failed on windows after JDK-8152502. >>> >>> Now I have the jtreg logs showing that JAR files can’t be deleted although >>> I still can’t reproduce them locally and on JPRT (will find out what’s the >>> difference tomorrow). >>> >> This looks okay to me. One thing you could do in the test is have >> JdepsUtil.Command be Closeable so that the tests can use try-with-resources >> and avoid failing with a file open. > > Good point. I’ll update that.
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8157391/webrev.01/index.html Mandy
