Hi Mandy,
On 6/3/16 12:55 AM, Mandy Chung wrote:
On Jun 2, 2016, at 3:11 PM, Daniel Fuchs <[email protected]> wrote:
>
> Hi Mandy,
>
> Looks good to me. Though I wonder whether a better fix would be
> to not tweak the bci for native methods in the native call that
> sets the value to 0 (I assume this is what happens somewhere
> since bci is initialized to -1 in Java).
>
I think you are suggesting to do the fix in the VM not to set
StackFrameInfo::bci if it’s a native method and hence it’d be left as -1. I
would prefer to do as much work in the java side as possible.
Yes - that's what I was suggesting - as I find it strange
that the VM will set bci=0 if no bci is available.
However your patch as it stands fixes the issue and is good
for me.
best regards,
-- daniel
