Hi Bhanu,

It can be problematic to change the default Locale for the entire process, especially since many tests are run in the same process. It would be preferable to set the locale in the DateTimeFormatter builder instead of changing the process wide Locale.

Please identify the specific test case to apply the fix only where needed.

Is it only tck.java.time.format.TCKDateTimeFormatterBuilder.test_appendZoneText_parseGenericTimeZonePatterns
where the failure is seen?

This would be an issue testing any pattern letter with locale dependent behavior.
The locale should be set explicitly in the test.

BTW, There is a predefined Locale.US that can be used, no need to construct a new Locale.

Roger



On 6/21/2016 6:31 AM, Bhanu Gopularam wrote:
Hi all,

May I request you to review fix for following issue
Bug id: https://bugs.openjdk.java.net/browse/JDK-8158880

Solution: To avoid test failure in non english locales, set the default locale 
while initial test setup

Webrev: http://cr.openjdk.java.net/~bgopularam/JDK-8158880/webrev.00/

Thanks,
Bhanu

Reply via email to