> On 21 Jun 2016, at 20:23, Steve Drach <steve.dr...@oracle.com> wrote: > > Hi Paul, > > I believe this webrev addresses your concerns: > > http://cr.openjdk.java.net/~sdrach/8150680/webrev.03/index.html >
141 private final int base_version; // BASE_VERSION.major() Why is this an instance field? make static and rename to BASE_VERSION_MAJOR. 142 private final Runtime.Version version; // current version 143 private final int major_version; // version.major() rename to versionMajor 144 private boolean notVersioned; // legacy constructor called Do you need this? Is this condition already met if versionMajor == BASE_VERSION_MAJOR ? i.e. why do you need to restrict to only the “legacy” constructor, since surely the same conditions should apply if a BASE_VERSION compatible version is passed into the version accepting constructor? Paul.
