Hi Claes, thank you. Of course you're right about the -run option; I've replaced this with a -D interface and pushed that version.
Best, Michael > Am 18.07.2016 um 12:57 schrieb Claes Redestad <claes.redes...@oracle.com>: > > Hi, > > On 2016-07-13 15:12, Michael Haupt wrote: >> Dear all, >> >> please review this fix. >> Bug: https://bugs.openjdk.java.net/browse/JDK-8161212 >> Webrev: http://cr.openjdk.java.net/~mhaupt/8161212/webrev.00/ > > fix looks OK, but I'm genuinely curious about best practice when it comes to > pass arguments to jtreg tests. How do I even pass -run to the actual test? > > Naively System properties seems easier and possibly less fragile (assuming > tests aren't run with a very strict security policy somewhere so that we'd > have to pair the test with the associated permissions): > > jtreg ... -Djava.lang.invoke.LoopCombinatorLongSignatureTest.run > java/lang/invoke/LoopCombinatorLongSignatureTest.java > > boolean run = > System.getProperty("java.lang.invoke.LoopCombinatorLongSignatureTest.run") != > null; > > Thanks! > > /Claes > >> >> Running the test in LambdaForm interpretation mode takes a long time. As the >> test is actually about capturing excessively long loop clause lists, running >> the constructed loop should be optional. The fix disables running the loop >> by default and introduces a -run option that can be used if the loop should >> actually be run. >> >> Thanks, >> >> Michael >> > -- <http://www.oracle.com/> Dr. Michael Haupt | Principal Member of Technical Staff Phone: +49 331 200 7277 | Fax: +49 331 200 7561 Oracle Java Platform Group | LangTools Team | Nashorn Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992 München Registergericht: Amtsgericht München, HRA 95603 Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167, 3543 AS Utrecht, Niederlande Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697 Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment
