On 31/07/2016 23:48, Felix Yang wrote:

Hi all,

please review the patch for some tests, which explicitly declare module dependencies to EE modules.

Bug: https://bugs.openjdk.java.net/browse/JDK-8157135

Webrev: http://cr.openjdk.java.net/~xiaofeya/8157135/webrev.00/

This is a partial fix left by https://bugs.openjdk.java.net/browse/JDK-8155088. The fix had been hold off for a moment, to wait for new jtreg with resolved https://bugs.openjdk.java.net/browse/CODETOOLS-7901671. Otherwise those tests will be ignored silently.
This looks okay. One thing to mention is that with the changes in jtreg then we should be able to drop -addmods from several of these tests. That is for a separate issue of course, also tied to the CLI changes as all these -addmods usages have been switched to --add-modules.

-Alan

Reply via email to