On 08/09/2016 03:04 PM, Claes Redestad wrote: > please review this set of small changes to reduce the number of classes > defined and pulled in when initializing java.lang.invoke > > Webrev: http://cr.openjdk.java.net/~redestad/8163370/webrev/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8163370
I'm too late here, but the change in StringConcatFactory code style is for the worse, IMO. Having a switch over enum does add readability. You might get the same class-count reduce effect by exposing the RecipeElement.tag as byte/int and switching over it. Thanks, -Aleksey
