On 17.08.2016 01:50, Paul Sandoz wrote: > On 8 Aug 2016, at 12:14, Patrick Reinhart <patr...@reini.net> wrote: >> Am 08.08.2016 um 18:55 schrieb Alan Bateman <alan.bate...@oracle.com>: >>> On 08/08/2016 17:29, Patrick Reinhart wrote: >>> >>>> : >>>> I tried to integrate your suggested changes here: >>>> http://cr.openjdk.java.net/~reinhapa/reviews/8161230/ClassLoader_StreamMethods.01 >>>> >>> I should have been clearer. A lazy implementation of >>> resources/systemResources methods won't throw any exceptions, instead any >>> I/O exceptions will be wrapped with an UncheckedIOException and then thrown >>> from the method that caused the access to take place. There are several >>> examples of this already. For the javadoc then this will be described in >>> the method description rather than a @throws. >>> >>> -Alan >> I hope that this version is more likely that what you meant… >> >> http://cr.openjdk.java.net/~reinhapa/reviews/8161230/ClassLoader_StreamMethods.02 >> >> <http://cr.openjdk.java.net/~reinhapa/reviews/8161230/ClassLoader_StreamMethods.02> >> > Perhaps consider: > > The loading of resources will occur when the returned stream is evaluated. > If the loading of resources > results in an {@code IOException} then the I/O exception is wrapped in an > {@link UncheckedIOException} > that is then thrown. > > Instead of <tt>…</tt> use {@code … } > > Paul.
Hi Paul, Thanks for the input. I integrated that into the version here: http://cr.openjdk.java.net/~reinhapa/reviews/8161230/ClassLoader_StreamMethods.03 Patrick
