I’ve updated the webrev to incorporate most of Paul’s suggestions. http://cr.openjdk.java.net/~sdrach/8164389/webrev.01/index.html <http://cr.openjdk.java.net/~sdrach/8164389/webrev.01/index.html>
> On Aug 18, 2016, at 5:01 PM, Paul Sandoz <paul.san...@oracle.com> wrote: > > >> On 18 Aug 2016, at 16:36, Steve Drach <steve.dr...@oracle.com> wrote: >> >> Hi, >> >> Please review this rather simple fix to JarFileSystem. >> >> issue: https://bugs.openjdk.java.net/browse/JDK-8164389 >> <https://bugs.openjdk.java.net/browse/JDK-8164389> >> webrev: http://cr.openjdk.java.net/~sdrach/8164389/webrev/index.html >> <http://cr.openjdk.java.net/~sdrach/8164389/webrev/index.html> >> > > JarFileSystem > — > > 162 private void walk(IndexNode inode, Consumer<IndexNode> process) { > 163 if (inode == null) return; > 164 if (inode.isDir()) > 165 walk(inode.child, process); > 166 else > 167 process.accept(inode); > 168 walk(inode.sibling, process); > 169 } > > I would recommend using braces, even for single statement blocks. > > > JFSTester > — > > You might wanna create a temporary jar file if possible, just in case the > test somehow fails to clean things up. > > > 80 public void TestWalk() throws IOException { > > Lower case for first letter. > > Paul.
