> On 27 Aug 2016, at 00:57, Alan Bateman <[email protected]> wrote: > > On 26/08/2016 17:48, Xueming Shen wrote: > >> Hi, >> >> This is a aged rfe from Paul's code review comments for the old code. base. >> The >> implementation has been changed lots since. Some has gone, some has been >> updated >> accordingly. Just went through the list and here is the change set for some >> minor issues >> still present. >> >> issue: https://bugs.openjdk.java.net/browse/JDK-8066577 >> webrev: http://cr.openjdk.java.net/~sherman/8066577/webrev > You might want to re-check the synchronization in JrtDirectoryStream, it > looks the next/hasNext methods are synchronizing on the Iterator instance. >
Yes, i missed that. The Iterator will need to synchronize on its enclosing instance. Paul.
