Hi John,
thank you very much - some comments are inlined below.
> Am 28.09.2016 um 08:26 schrieb John Rose <john.r.r...@oracle.com>:
>
> Reviewed. This is a huge leap forward.
>
> A few small comments to consider:
>
> In FacLoop, the argument k should be named acc:
> +- int fin(int i, int k) { return k; }
> ++ int fin(int i, int acc) { return acc; }
>
> This affects *two* files, a JDE.java and MHs.java.
Fixed.
> Fix awkwardness: s/A similar same example/A similar example
Fixed.
> I'm really glad to see the FacLoop example, BTW; I think it is often the
> right pattern to use.
>
> There is a redundant phrase in the javadoc which reads oddly:
>
> + A non-void value returned from the body (which must also be of type V)
>
> But the previous line just defined V as the return value of the body:
> + If the body handle returns a non-void type V, a leading loop iteration
> variable of that type is also present.
>
> Seems like you can just omit "(which must also be of type V)" or shorten it
> to "(of type V)" or perhaps "(which is the leading iteration variable)". In
> any case, the role of "V" is fully described in the bullet item list that
> follows.
Right; I've changed this to "(of type V)".
> The whole section beginning "Example. As a consequence of step 1A above" is
> kind of fluffy. It doesn't add much, although it is technically correct.
> You could take it out if you feel the same. (The fact that the "pred" guys
> are assumed to take no arguments means that it's a pretty useless loop.) I
> don't mind leaving it in, though, in the interests of converging this review
> process!
I'd rather leave it in; I think I added it at some point in response to a
clarification request from JCK.
> Thank you for putting in the extra working examples. That will really help
> users pick the right patterns.
Yes. It's interesting new API that deserves some examples. ;-)
I'll push shortly, with the aforementioned modifications.
Best,
Michael
--
<http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG | Schiffbauergasse 14 | 14467 Potsdam, Germany
ORACLE Deutschland B.V. & Co. KG | Hauptverwaltung: Riesstraße 25, D-80992
München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V. | Hertogswetering 163/167,
3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Nederland, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment
