Hi Mandy The code changes look good.
A couple of minor suggestions This looks good. Only thought I had is err.genmoduleinfo.unnamed.package={0} contains unnamed package; not a valid module to generate module-info.java perhaps change it to: {0} contains an unnamed package that is not allowed in a module. err.genmoduleinfo.not.jarfile={0} is a modular JAR file; not valid for --generate-module-info option I might tweak this to be: {0} is a modular JAR file and may not be specified with the —generate-module-info option HTH, Best, Lance > On Oct 4, 2016, at 10:50 PM, Mandy Chung <mandy.ch...@oracle.com> wrote: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8166846/webrev.00/ > > This improves jdeps error message to indicate that a JAR file containing > unnamed package is not valid to generate module-info.java. > > Mandy <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com <mailto:lance.ander...@oracle.com>